Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds SAGP as an experimental expo plugin feature #4440

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
56bdc03
Adds SAGP as an experimental expo plugin feature
antonis Jan 13, 2025
f168bd3
Updates changelog
antonis Jan 13, 2025
5984d12
Adds extra SAGP options
antonis Jan 14, 2025
6adb2c0
Adds tests
antonis Jan 14, 2025
d6ebdf3
Merge branch 'main' into antonis/experimental-expo-sagp
antonis Jan 14, 2025
4e0e78f
Fix configuration typo
antonis Jan 14, 2025
c153ed7
Remove autoInstallationEnabled
antonis Jan 16, 2025
2539a24
Hardcode SAGP version and use enableAndroidGradlePlugin
antonis Jan 16, 2025
6dbf9b5
Set tracingInstrumentation disabled as it is not currently supported …
antonis Jan 16, 2025
59e54ce
Deconstruct the options arguments to avoid duplication
antonis Jan 16, 2025
7b053f5
Use guard for checking groovy
antonis Jan 16, 2025
b1230bd
Use warnOnce instead of throwing an error
antonis Jan 16, 2025
9d6d9d2
Check that android/build.gradle uses Groovy
antonis Jan 16, 2025
cf55ce4
warn when dependency already exists
antonis Jan 16, 2025
f04a2c7
warnOnce if failed to modify build.gradle
antonis Jan 16, 2025
051f896
Merge branch 'main' into antonis/experimental-expo-sagp
antonis Jan 16, 2025
c430747
Add a changelog link to the documentation
antonis Jan 16, 2025
73f7b6b
Merge branch 'main' into antonis/experimental-expo-sagp
antonis Jan 24, 2025
2302390
Merge branch 'main' into antonis/experimental-expo-sagp
antonis Jan 30, 2025
56d4df1
Merge branch 'main' into antonis/experimental-expo-sagp
antonis Feb 4, 2025
75bd2f0
Update changelog
antonis Feb 4, 2025
e7e55c6
Merge branch 'main' into antonis/experimental-expo-sagp
antonis Feb 11, 2025
d501302
Fix changelog
antonis Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deconstruct the options arguments to avoid duplication
antonis committed Jan 16, 2025
commit 59e54ce4e668c12aac08c5cd63c4af940180fd92
20 changes: 12 additions & 8 deletions packages/core/plugin/src/withSentryAndroidGradlePlugin.ts
Original file line number Diff line number Diff line change
@@ -15,15 +15,19 @@ export interface SentryAndroidGradlePluginOptions {
* Adds the Sentry Android Gradle Plugin to the project.
* https://docs.sentry.io/platforms/react-native/manual-setup/manual-setup/#enable-sentry-agp
*/
export function withSentryAndroidGradlePlugin(config: any, options: SentryAndroidGradlePluginOptions = {}): any {
export function withSentryAndroidGradlePlugin(
config: any,
{
includeProguardMapping = true,
dexguardEnabled = false,
autoUploadProguardMapping = true,
uploadNativeSymbols = true,
autoUploadNativeSymbols = true,
includeNativeSources = true,
includeSourceContext = false,
}: SentryAndroidGradlePluginOptions = {},
): any {
const version = '4.14.1';
const includeProguardMapping = options.includeProguardMapping ?? true;
const dexguardEnabled = options.dexguardEnabled ?? false;
const autoUploadProguardMapping = options.autoUploadProguardMapping ?? true;
const uploadNativeSymbols = options.uploadNativeSymbols ?? true;
const autoUploadNativeSymbols = options.autoUploadNativeSymbols ?? true;
const includeNativeSources = options.includeNativeSources ?? true;
const includeSourceContext = options.includeSourceContext ?? false;

// Modify android/build.gradle
const withSentryProjectBuildGradle = (config: any): any => {