Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new trace_propagation_targets configuration #2079

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jul 27, 2023

to set outgoing targets for trace header propagation according to https://develop.sentry.dev/sdk/performance/#tracepropagationtargets
closes #2078

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 61.53% and no project coverage change.

Comparison is base (7764384) 83.23% compared to head (e651d76) 83.23%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         119      119           
  Lines        5665     5671    +6     
=======================================
+ Hits         4715     4720    +5     
- Misses        950      951    +1     
Files Changed Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 29.78% <37.50%> (+0.89%) ⬆️
sentry-ruby/lib/sentry/configuration.rb 84.61% <100.00%> (+0.19%) ⬆️
...try-ruby/lib/sentry/interfaces/single_exception.rb 65.71% <100.00%> (+1.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review July 27, 2023 13:55
@sl0thentr0py sl0thentr0py requested a review from st0012 July 27, 2023 13:55
sentry-ruby/lib/sentry/net/http.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/net/http.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/net/http.rb Show resolved Hide resolved
@sl0thentr0py sl0thentr0py requested review from st0012 and removed request for st0012 August 2, 2023 11:58
@sl0thentr0py sl0thentr0py merged commit bc0f8ce into master Aug 2, 2023
96 of 97 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/trace-prop-targets branch August 2, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trace_propagation_targets
2 participants