-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing without performance #2084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
sl0thentr0py
force-pushed
the
neel/twp
branch
6 times, most recently
from
August 16, 2023 12:17
9ffcc1f
to
23a4d06
Compare
@st0012 still gonna write some specs and test but feel free to start reviewing if you have time and let me know if you have questions on why we are doing this! |
st0012
reviewed
Aug 20, 2023
sl0thentr0py
force-pushed
the
neel/twp
branch
3 times, most recently
from
August 29, 2023 13:22
83541fd
to
c6d3bfe
Compare
cleptric
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is 1/2 to enable Tracing without Performance, i.e. make sure all our events are connected even if they are not Transactions.
This enables use cases such as Errors / Transactions / Replays etc all being connected across services and not just Transactions.
Summary of changes
PropagationContext
class that generates trace/span ids and baggage irrespective of whether there are transactions/spans active or notScope
Sentry.get_traceparent
Sentry.get_baggage
Sentry.get_trace_propagation_headers
dynamic_sampling_context
toEvent
fromTransactionEvent
since all events will now have this infonet/http
patch to set propagation headerscloses #2056
also see #2089