Duplicate Rails.logger
before assigning it to the SDK
#2086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this while investigating #2031: If we don't duplicate
Rails.logger
, configurations made to the SDK's logger will be applied to the Rails logger as well.For example, in an Rails app:
Will make the Rails logger's level to be
Logger::WARN
too. I think most users wouldn't expect this and will find it confusing.