Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate HTTP span data conventions with OpenTelemetry #2093

Merged
merged 1 commit into from
Sep 4, 2023

Consolidate Sentry::Span::DataConventions with OpenTelemetry

fd17ccf
Select commit
Loading
Failed to load commit list.
Merged

Consolidate HTTP span data conventions with OpenTelemetry #2093

Consolidate Sentry::Span::DataConventions with OpenTelemetry
fd17ccf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 28, 2023 in 0s

83.25% (-0.01%) compared to 86dfaea

View this Pull Request on Codecov

83.25% (-0.01%) compared to 86dfaea

Details

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.01% ⚠️

Comparison is base (86dfaea) 83.25% compared to head (fd17ccf) 83.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
- Coverage   83.25%   83.25%   -0.01%     
==========================================
  Files         119      119              
  Lines        5674     5679       +5     
==========================================
+ Hits         4724     4728       +4     
- Misses        950      951       +1
Files Changed Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 29.78% <0.00%> (ø)
...rails/tracing/action_controller_subscriber_spec.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/tracing_spec.rb 99.42% <100.00%> (ø)
sentry-ruby/lib/sentry/span.rb 87.95% <100.00%> (+0.77%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov