Update setup for Rails 7.1 #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2125 +/- ##
==========================================
- Coverage 97.48% 97.27% -0.22%
==========================================
Files 88 96 +8
Lines 3382 3596 +214
==========================================
+ Hits 3297 3498 +201
- Misses 85 98 +13
|
st0012
force-pushed
the
rails-7-1
branch
3 times, most recently
from
8d38716
to
253fc87
Compare
st0012
force-pushed
the
rails-7-1
branch
4 times, most recently
from
3636da7
to
5fe75ff
Compare
st0012
commented
Oct 7, 2023
| # We need to cleanup Rails.logger because after https://github.com/rails/rails/pull/49417 | ||
| # Rails.logger could get recreated with the previous logger value and become deeply nested broadcast logger | ||
| Rails.logger = nil | ||
| end |
There was a problem hiding this comment.
The behaviour has been addressed in rails/rails#49462, so we don't need this anymore.
sl0thentr0py
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rails 7.1 has been officially released, we update
sentry-rails' setup for it.This also addresses build failures in
sentry-delayed_jobandsentry-sidekiq.#skip-changelog