Update sentry-sidekiq for Sidekiq 7.1.5 #2126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Update sentry-sidekiq for Sidekiq 7.1.5 ([#2126](https://github.com/getsentry/sentry-ruby/pull/2126))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified lines are covered by tests ✅
... and 30 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
In sidekiq/sidekiq#6051, Sidekiq changed the expected parameters on the error handler. However, because it assumes error handler to be a Proc, it uses `#arity` for checking the number of parameters. This is not compatible with our error handler, which is a class.
st0012
force-pushed
the
fix-sidekiq-error-handler
branch
from
9f65ffc
to
44cabe0
Compare
|
@sl0thentr0py Oh nice. I guess we just need to wait then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sidekiq/sidekiq#6051, Sidekiq changed the expected parameters on the error handler. However, because it assumes error handler to be a Proc, it uses
#arityfor checking the number of parameters. This is not compatible with our error handler, which is a class.