-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #2388
Improve CI #2388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
- Coverage 98.69% 98.67% -0.02%
==========================================
Files 210 210
Lines 13910 13910
==========================================
- Hits 13728 13726 -2
- Misses 182 184 +2
|
9a91fd4
to
166768b
Compare
166768b
to
7753850
Compare
@@ -1,6 +1,6 @@ | |||
require 'spec_helper' | |||
|
|||
RSpec.describe Sentry::Rack::CaptureExceptions, when: :rack_available? do | |||
RSpec.describe 'Sentry::Rack::CaptureExceptions', when: :rack_available? do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not beautiful but it was needed as this constant may not be defined if rack is not available
The diff in cov against master is most likely caused by the fact that this PR runs coverage under 3.3 and master 3.2, so we can just ignore it |
#skip-changelog