Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #2388

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Improve CI #2388

merged 4 commits into from
Aug 26, 2024

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Aug 26, 2024

  • Exlude rubocop from CI's bundle - this was needed because we want to test things when rack is not installed too and unfortunately rubocop-rails depends on rack, so rack was always installed
  • Measure coverage on latest Ruby 3.3 - we're gonna have specs that run only under 3.3 once Vernier branch is merged and w/o this tweak coverage would go down
  • Add rack 3.1 and redis 5.3 to the test matrix

#skip-changelog

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (9d23b6f) to head (7753850).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
- Coverage   98.69%   98.67%   -0.02%     
==========================================
  Files         210      210              
  Lines       13910    13910              
==========================================
- Hits        13728    13726       -2     
- Misses        182      184       +2     
Components Coverage Δ
sentry-ruby 99.05% <100.00%> (-0.02%) ⬇️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
...y-ruby/spec/sentry/rack/capture_exceptions_spec.rb 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@solnic solnic marked this pull request as ready for review August 26, 2024 07:27
@@ -1,6 +1,6 @@
require 'spec_helper'

RSpec.describe Sentry::Rack::CaptureExceptions, when: :rack_available? do
RSpec.describe 'Sentry::Rack::CaptureExceptions', when: :rack_available? do
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not beautiful but it was needed as this constant may not be defined if rack is not available

@solnic
Copy link
Collaborator Author

solnic commented Aug 26, 2024

The diff in cov against master is most likely caused by the fact that this PR runs coverage under 3.3 and master 3.2, so we can just ignore it

@sl0thentr0py sl0thentr0py merged commit 51299fa into master Aug 26, 2024
140 of 141 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/improve-ci branch August 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants