Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error events missing a DSC when there's an active span #2408

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

sl0thentr0py
Copy link
Member

We were actually missing the DSC in the envelope header in the case when we have a non-transaction event (like an error) being sent but with an active span/transaction on the scope.

fixes #2400

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (c3bcfa0) to head (57e979b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
- Coverage   98.69%   98.68%   -0.01%     
==========================================
  Files         210      210              
  Lines       13922    13935      +13     
==========================================
+ Hits        13740    13752      +12     
- Misses        182      183       +1     
Components Coverage Δ
sentry-ruby 99.05% <100.00%> (-0.01%) ⬇️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 97.11% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/propagation_context.rb 100.00% <ø> (ø)
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/span.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/scope_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/span_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-twp-errors-with-active-span branch from 51e4b1d to 57e979b Compare September 19, 2024 12:42
@sl0thentr0py sl0thentr0py merged commit 05c4675 into master Sep 19, 2024
137 of 140 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-twp-errors-with-active-span branch September 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on a page load in a trace containing a replay doesn't include the replay_id
2 participants