-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Sentry.{close,get_main_hub} thread-safe #2436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
requested review from
st0012 and
sl0thentr0py
and removed request for
st0012
October 18, 2024 08:23
|
sl0thentr0py
requested changes
Oct 18, 2024
solnic
force-pushed
the
solnic/make-closing-thread-safe
branch
from
October 18, 2024 21:15
2fea332
to
ffc67f0
Compare
solnic
changed the title
Make Sentry.close thread-safe
Make Sentry.{close,get_main_hub} thread-safe
Oct 18, 2024
solnic
force-pushed
the
solnic/make-closing-thread-safe
branch
3 times, most recently
from
October 18, 2024 21:34
e4669f2
to
4fe0b8d
Compare
sl0thentr0py
approved these changes
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2436 +/- ##
==========================================
- Coverage 98.34% 98.17% -0.17%
==========================================
Files 126 126
Lines 4703 4725 +22
==========================================
+ Hits 4625 4639 +14
- Misses 78 86 +8
|
st0012
approved these changes
Oct 19, 2024
solnic
force-pushed
the
solnic/make-closing-thread-safe
branch
from
October 19, 2024 21:07
18118d5
to
4fe0b8d
Compare
solnic
force-pushed
the
solnic/make-closing-thread-safe
branch
2 times, most recently
from
October 20, 2024 21:33
b33e3dd
to
b76231d
Compare
solnic
force-pushed
the
solnic/make-closing-thread-safe
branch
from
October 20, 2024 21:40
b76231d
to
25454b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're dealing with a bunch of global vars in
Sentry.close
, it should be wrapped in a mutex sync because threads may be accessing these vars while Sentry is closing, and THAT probably causes #2386 and #2396.#skip-changelog