-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TracingDriverForV32 for DBAL >= 3.2
#723
Conversation
73a851b
to
df90a7a
Compare
@cleptric Any idea why the tests are not running anymore? It worked the first push, but then stopped. I feel there is an error on the workflow (that I modified) but I cannot see it. |
ea8ed04
to
2223335
Compare
Seems to have ran just fine now 😄 Maybe GH was a little slow starting them. |
c7a33bc
to
cb92a10
Compare
It seems that PHP-CS-Fixer is broken, as it produces many changes unrelated to my PR. |
71aed08
to
e69e348
Compare
It looks like the latest version of PHPCS contains some incompatible changes with prior versions. You might pin the version to something below 3.17 to get the tests passing. |
3027a7d
to
df8b4b8
Compare
6bb6ae2
to
5498ff4
Compare
There is a problem with PHP-CS-Fixer 3.17.0 @cleptric suggested pinning it.
Fixes ``` 1x: Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Sentry\SentryBundle\Tests\End2End\App\Command\MainCommand" now to avoid errors or add an explicit @return annotation to suppress this message. ```
59bf5e6
to
28509fb
Compare
Applied feedback, we're green again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I just wonder if the TracingDriverForV3Point2
class should be renamed to TracingDriverForV32
as that is the naming convention used in the DBAL itself (and that we used too to name some test methods), but I will leave the final decision up to you.
This driver does not implement the deprecated `VersionAwarePlatformDriver`. It's automatically picked when `doctrine/dbal` version `3.2.0` or higher is installed. Fixes getsentry#579
>= 3.2
I didn't like the Point either... but 32 also feels weird. Anyway, since that's the convention, let's follow that. |
Yea, totally agree on everything you said 👍 |
Can this be merged? 🙏 |
Thanks, and tagged please 🙏 |
Any updates? Are looking forward to |
This is released since 4.9.0 |
Nope, it was reverted in |
This driver does not implement the deprecated
VersionAwarePlatformDriver
.It's automatically picked when
doctrine/dbal
version3.2.0
or higher is installed.Fixes #579