Add debug symbols upload

[tustanivsky]

Resolves #47
Resolves #57
Resolves #60

It will also make sense to automate Sentry CLI update in a way similar to other plugin dependencies (#60)

[vaind]

Is this file normally under version control? If so, we shouldn't use it for sentry CLI configuration (a.k.a sentry.properties) as that's supposed to be excluded from git due to the auth-token.

[tustanivsky]

Yes, DefaultEngine.ini is an essential part of any UE project that keeps all of its settings (including plugins) and usually it's under source control. Though I don't think it can cause any issues for plugin users since they are likely to take care of securing their project config files. Or did I get it wrong?

[vaind]

Even if it's in a private repo, unless it's a single-person project, it's best not to commit auth tokens into source control. Additionally, this disqualifies any open-source games.

[vaind]

I'd suggest sticking to a single sentry.propertiies file, regardless of the platform

[tustanivsky]

Don't we have the exact same issue with Unity then? AFAIK there auth token is stored in a separate asset (SentryCliOptions scriptible object) which apparently could be a part of the game as well

[vaind]

yes, we use the sentry.properties file on windows without an issue with Unity

[vaind]

Practical illustration why we shouldn't store the settings in the same file as everything else - from the in-repo sample PR (#64):

How can we move that to a different location so the "shared" file doesn't change?

[tustanivsky]

How can we move that to a different location so the "shared" file doesn't change?

We can replace user credentials here with a path to sentry.properties file which won't be publicly accessible. Later we can add some editor tool that will automate the creation of this file. What do you think?

[vaind]

sounds good to me

[tustanivsky]

Alright, no more user credentials in DefaultEngine.ini. Now in order to obtain auth token and other stuff for Sentry CLI path to sentry.properties file has to be provided firs. Apparently not an ideal solution since it may vary on different machines, though at least we've removed the risk of compromising sensitive data

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4fa854f

[vaind]

@tustanivsky for Android, we need to update the UPL file - how can we reference the ProjectDir and the Sentry.PropertiesFilePath here?

sentry-unreal/plugin-dev/Source/Sentry/Sentry_Android_UPL.xml

Line 15 in 3a0d8a1

<copyFile src="$S(PluginDir)/../../Resources/sentry.properties" dst="$S(BuildDir)/gradle/sentry.properties" />

[tustanivsky]

@tustanivsky for Android, we need to update the UPL file - how can we reference the ProjectDir and the Sentry.PropertiesFilePath here?

sentry-unreal/plugin-dev/Source/Sentry/Sentry_Android_UPL.xml

Line 15 in 3a0d8a1

<copyFile src="$S(PluginDir)/../../Resources/sentry.properties" dst="$S(BuildDir)/gradle/sentry.properties" />

$S(ProjectDir) should give us the path to the project directory and the sentry.properties file can be referenced via $S(PropertiesFilePath) variable which is defined above.

It actually looks like something went wrong during recent merges - src should be $S(PropertiesFilePath)

[vaind]

It actually looks like something went wrong during recent merges - src should be $S(PropertiesFilePath)

fixed

please have a look at my changes and feel free to merge. Also, can you please manually check macOS? I've only tested windows & android with these changes