feat(rn): Update React Native wizard to use clack prompts #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
reviewed
Oct 2, 2023
Lms24
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Great work! I had a couple of comments but nothing that I'd consider blocking. Feel free to disregard my comments regarding coloring or UI, I'm just trying to adhere to our develop specifications. We can also just iterate on this later.
(sorry for the individual reviews instead of one w/ many comments, seems I clicked the wrong button in VSCode every time 😅 )
|
@Lms24 Thanks for the comment and the notes about the UI, I would like the wizards to follow the definition if possible, so I adjusted the prompts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the RN Wizard implementation to use clack for prompts and shared tools from
src/**/*. This PR aims to change the wizard behavior as little as possible and only focuses on the clack changes. For this reason, telemetry was not implemented and is disabled at the moment. (Will be added in follow up PR.)lib/**/*RN implementation was completely removed.This is a breaking change for RN Wizard
--skip-connectis not supported anymore--quiteis not supported anymore--platformis not supported anymore (the SDK check is android, ios are present and patch them if they are)--signupis not supported anymore (the wizard new impl asks if the user has an account)Example of successful install flow:
Example of uninstall flow:
Example of pod install error:
