Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
mifu67 committed Jan 16, 2025
1 parent 37a19bc commit 7a47aca
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/sentry/workflow_engine/migration_helpers/alert_rule.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ def update_migrated_alert_rule(alert_rule: AlertRule, updated_fields: dict[str,
]
| None
):
# TODO: maybe pull this into a helper method?
try:
alert_rule_detector = AlertRuleDetector.objects.get(alert_rule=alert_rule)
except AlertRuleDetector.DoesNotExist:
Expand Down Expand Up @@ -461,8 +460,6 @@ def update_migrated_alert_rule(alert_rule: AlertRule, updated_fields: dict[str,
# reset detector status, as the rule was updated
detector_state.update(active=False, state=DetectorPriorityLevel.OK)

# TODO: do we need to create an audit log entry here?
# do we need to return the detector's data conditions/DCG?
return detector_state, detector


Expand Down

0 comments on commit 7a47aca

Please sign in to comment.