ref: NuqsTestingAdapter #102387
Merged
ref: NuqsTestingAdapter #102387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
franky47
reviewed
Oct 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102387 +/- ##
========================================
Coverage 80.96% 80.96%
========================================
Files 8819 8819
Lines 390155 390155
Branches 24832 24832
========================================
Hits 315878 315878
Misses 73911 73911
Partials 366 366 |
scttcper
reviewed
Oct 30, 2025
| ? `${location.pathname}${queryString}` | ||
| : location.pathname; | ||
|
|
||
| // The navigate function from TestRouter already wraps this in act() |
scttcper
reviewed
Oct 30, 2025
Comment on lines
+45
to
+48
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const location = useLocation(); | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const navigate = useNavigate(); |
There was a problem hiding this comment.
i think this area was most surprising to me after looking at the result of what was vibe coded
There was a problem hiding this comment.
yeah I tried moving it out but it didn’t work :/
I think it’s good enough like this, I’d appreciate a ✅ so we can merge it, as we already have PRs blocked by this 🙏
scttcper
approved these changes
Oct 30, 2025
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
Continued from - #101616 This PR creates a `SentryNuqsTestingAdapter` that uses our `useLocation` and `useNavigate` hooks to interface with nuqs in tests so that it uses our testing router as the source of truth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from
This PR creates a
SentryNuqsTestingAdapterthat uses ouruseLocationanduseNavigatehooks to interface with nuqs in tests so that it uses our testing router as the source of truth