feat(ai-generations): Add generations table #102389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| )?.content; | ||
| return typeof lastUserMessage === 'string' | ||
| ? lastUserMessage | ||
| : lastUserMessage[0].text.toString(); |
There was a problem hiding this comment.
Bug: Unsafe Type Handling in getLastUserMessage
The getLastUserMessage function makes an unsafe assumption that if lastUserMessage isn't a string, it's an array with a text property at its first element. This can cause runtime errors if lastUserMessage is null, undefined, an empty array, or if lastUserMessage[0] lacks text.
There was a problem hiding this comment.
there is a try catch around it
| DrawerUrlParams.SELECTED_SPAN, | ||
| parseAsString.withOptions({history: 'replace'}) | ||
| ); | ||
|
|
There was a problem hiding this comment.
Bug: Inconsistent State After Drawer Closure
The removeQueryParams function clears selectedTrace but not selectedSpan. Since the hook now manages both trace and span URL parameters, closing the drawer can leave stale spanIds in the URL, causing inconsistent state.
ArthurKnaus
deleted the
arthurknaus/tet-1286-ai-generations-page-table
branch
isabellaenriquez
pushed a commit
that referenced
this pull request
Oct 31, 2025
<img width="1205" height="305" alt="Screenshot 2025-10-30 at 12 47 31" src="https://github.com/user-attachments/assets/3b601055-3848-44e8-b669-a5f7458c144f" /> - closes [TET-1286: AI Generations Page - Table](https://linear.app/getsentry/issue/TET-1286/ai-generations-page-table) - closes [TET-1287: AI Generations Page - Input/Output Columns](https://linear.app/getsentry/issue/TET-1287/ai-generations-page-inputoutput-columns)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.