fix(service-incidents): Find incidents with components in updates #102412
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Find any incident with an update that includes any of the componentFilter. | ||
| inc.incident_updates.some(update => | ||
| update.affected_components?.some(c => componentFilter.includes(c.code)) | ||
| ) |
Contributor
There was a problem hiding this comment.
Bug: Component Filter Bypasses Resolved Status
The component filter applies to the original incidents array instead of the already-filtered filteredIncidents. When both !includeResolved and componentFilter are active, resolved incidents may incorrectly appear in the results, as the resolved status filtering is bypassed.
scttcper
approved these changes
Oct 31, 2025
evanpurkhiser
deleted the
evanpurkhiser/fix-service-incidents-find-incidents-with-components-in-updates
branch
jjbayer
pushed a commit
that referenced
this pull request
Nov 3, 2025
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.