Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crons): Update check-ins with trace_id if sent #51554

Closed
wants to merge 1 commit into from

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Jun 23, 2023

Updates the check-in trace_id if it is sent in the payload as python SDK only sends it on closing check-in

@rjo100 rjo100 requested a review from a team as a code owner June 23, 2023 22:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #51554 (356c28e) into master (06e23e1) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #51554     +/-   ##
=========================================
- Coverage    81.29    81.28   -0.01     
=========================================
  Files        4902     4902             
  Lines      205468   205468             
  Branches    11083    11083             
=========================================
- Hits       167016   167013      -3     
- Misses      38206    38209      +3     
  Partials      246      246             
Impacted Files Coverage Δ
src/sentry/monitors/consumers/monitor_consumer.py 92.54% <75.00%> (ø)

... and 2 files with indirect coverage changes

@rjo100
Copy link
Contributor Author

rjo100 commented Jun 26, 2023

Might not want to add this...discussing with SDK teams now

@rjo100
Copy link
Contributor Author

rjo100 commented Jul 12, 2023

Fixed by getsentry/sentry-python#2205

@rjo100 rjo100 closed this Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@asottile-sentry asottile-sentry deleted the rjo100/update-checkin-trace branch December 27, 2023 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants