Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(insights): rename resource module to asset module #70951
ref(insights): rename resource module to asset module #70951
Changes from 16 commits
3baab1c
35f1711
84f3ba3
b8918ea
17fd896
06218b7
22cff42
609dbbb
b953b58
c90f066
0b916e4
a350a9d
a36a5f4
0cf801c
7eb240d
50fb90b
2edb494
e245c28
c187147
4757bb5
794ed11
55a5815
c1864a5
8950717
1213fe2
aeb0a6e
80b2712
e8d0619
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 7 in static/app/components/events/interfaces/spans/spanSummaryButton.tsx
GitHub Actions / typescript and lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/browser/assets
and/browser/resources
will just route to the same component so we don't have to rely on the organization to setup routesCheck failure on line 42 in static/app/views/performance/browser/resources/index.tsx
GitHub Actions / typescript and lint
Check failure on line 24 in static/app/views/performance/browser/resources/resourceSummaryPage/index.tsx
GitHub Actions / typescript and lint
Check failure on line 10 in static/app/views/performance/browser/resources/resourceSummaryPage/resourceSummaryCharts.tsx
GitHub Actions / typescript and lint
Check failure on line 19 in static/app/views/performance/browser/resources/resourceView/resourceTable.tsx
GitHub Actions / typescript and lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefixed with
Performance
so that once we move to insights, we just delete these and it all makes sense still. If we prefixed with insights, we would either have to live with it, or refactor this variable.