chore(sentryapp): new SentryAppWebhookRequestsEndpoint control endpoint
#81676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
cathteng
reviewed
Dec 4, 2024
| publish_status = { | ||
| "GET": ApiPublishStatus.UNKNOWN, | ||
| } | ||
| permission_classes = (SentryAppStatsPermission,) |
There was a problem hiding this comment.
should this be SentryAppPermission?
There was a problem hiding this comment.
SentryAppStatsPermission is the one to use for this endpoint, since we only want the integrator org to be able to get the requests/stats.
There was a problem hiding this comment.
there seems to only be a GET for this endpoint, so only the GET scopes would apply. the PARANOID_GET scopes from SentryAppPermission applies to anyone with member and above permissions which also seems appropriate
ameliahsu
force-pushed
the
mia/sentry-app/v2
branch
from
3c9862c to
a117f74
Compare
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Bundle ReportChanges will decrease total bundle size by 3.8kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
ameliahsu
changed the title
SentryAppRequestsEndpointV2 control endpointSentryAppWebhookRequestsEndpoint control endpoint
src/sentry/sentry_apps/api/serializers/sentry_app_webhook_request.py
Outdated
Show resolved
Hide resolved
tests/sentry/sentry_apps/api/endpoints/test_sentry_app_webhook_requests.py
Show resolved
Hide resolved
tests/sentry/sentry_apps/api/endpoints/test_sentry_app_webhook_requests.py
Show resolved
Hide resolved
src/sentry/sentry_apps/api/endpoints/sentry_app_webhook_requests.py
Outdated
Show resolved
Hide resolved
src/sentry/sentry_apps/api/endpoints/sentry_app_webhook_requests.py
Outdated
Show resolved
Hide resolved
src/sentry/sentry_apps/api/serializers/sentry_app_webhook_request.py
Outdated
Show resolved
Hide resolved
tests/sentry/sentry_apps/api/endpoints/test_sentry_app_webhook_requests.py
Show resolved
Hide resolved
src/sentry/sentry_apps/api/serializers/sentry_app_webhook_request.py
Outdated
Show resolved
Hide resolved
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
ameliahsu
force-pushed
the
mia/sentry-app/v2
branch
from
d012277 to
174e0c3
Compare
src/sentry/sentry_apps/api/serializers/sentry_app_webhook_request.py
Outdated
Show resolved
Hide resolved
| @@ -100,18 +113,26 @@ def _get_all_from_buffer( | |||
| else: | |||
| return self.client.lrange(buffer_key, 0, BUFFER_SIZE - 1) | |||
|
|
|||
| def _get_requests(self, event: str | None = None, error: bool = False) -> list[dict[str, Any]]: | |||
| def _get_requests( | |||
| self, event: str | list[str] | None = None, error: bool = False | |||
There was a problem hiding this comment.
How hard would it be to make event only be a list of strings so we don't have to the check to see if it's one or multiple ? Also idk if there was a discussion or anything about this already
There was a problem hiding this comment.
mmm I think we can get rid of the str | once we get rid of the old endpoint, I'd rather not modify the old endpoint rn
Comment on lines
+87
to
+88
| filter: SentryAppRequestFilterArgs, | ||
| datetime_org_filter: DatetimeOrganizationFilterArgs, |
There was a problem hiding this comment.
Curious Q: why are the datetime and event filters applied in different places ? (it's not a big deal but was just wondering if there was some context behind it ?)
There was a problem hiding this comment.
event filtering is done within buffer.get_requests inside of get_buffer_requests_for_region, while the datetime and org filtering is done to the results of that call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a new control endpoint in order to fetch sentry app requests from all regions.
Note:
Since installation requests are stored in control, we also have to fetch requests from the control buffer. We specifically query the region buffers for non-installation event requests to avoid duplicate requests (in case a region shares the same buffer as control).