feat(issue-details): Display the resolution/archival reason on new UI #83555
+247
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83555 +/- ##
==========================================
- Coverage 87.53% 87.53% -0.01%
==========================================
Files 9406 9406
Lines 537407 537384 -23
Branches 21163 21157 -6
==========================================
- Hits 470397 470376 -21
+ Misses 66664 66662 -2
Partials 346 346 |
| export function renderResolutionReason({ | ||
| statusDetails, | ||
| project, | ||
| organization, |
There was a problem hiding this comment.
is there a reason we can't use useOrganization here?
There was a problem hiding this comment.
Didn't think it was worth refactoring the whole thing to be a hook. I'd have to look at the logic as well to ensure calling useRenderResolutionReason wouldn't cause issues if the issue wasn't resolved since hooks always need to be called and all that.
Passing a new prop skips all that
Bundle ReportChanges will increase total bundle size by 43.96kB (0.14%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the activity was still present, we stopped showing a banner for reasons associated with a resolution or archival. Those are brought back now alongside the new banner.