feat(ui): Switch bootstrap requests to fetch #83561
Open
+86
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing some tech debt around the bootstrap requests. Adds stronger types and moves towards a fetch api that is similar to requestPromise. We can't seem to use requestPromise because react is expected to have already started.
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
scttcper
commented
Jan 16, 2025
| }; | ||
| return [json, response.statusText, responseMeta]; | ||
| } | ||
| throw [response.status, response.statusText]; |
There was a problem hiding this comment.
i'm not sure if anything actually uses these weird tuples thrown but that's what we were doing before
Bundle ReportChanges will increase total bundle size by 31.3MB (100.0%) ⬆️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some tech debt around the bootstrap requests. Adds stronger types and moves towards a fetch api that is similar to requestPromise.
We can't seem to use requestPromise because react is expected to have already started.
Starting with tech debt as part of https://www.notion.so/sentry/Tech-Spec-Frontend-Bootstrap-Cache-Project-Loading-Performance-1748b10e4b5d80759127c15d3772e063