feat(rpc): Support RPC aggregate filters #83590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for aggregate filters for the table RPC. Requires getsentry/snuba#6776.
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Jan 16, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83590 +/- ##
===========================================
+ Coverage 42.10% 87.59% +45.49%
===========================================
Files 9459 9485 +26
Lines 537327 538709 +1382
Branches 21221 21167 -54
===========================================
+ Hits 226230 471905 +245675
+ Misses 310748 66456 -244292
+ Partials 349 348 -1 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
This adds support for aggregate filters for the table RPC. Requires getsentry/snuba#6776.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for aggregate filters for the table RPC.
Requires getsentry/snuba#6776.