Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix typing for group serializer #83598

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team January 16, 2025 19:12
@asottile-sentry asottile-sentry requested review from a team as code owners January 16, 2025 19:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 16, 2025
@asottile-sentry asottile-sentry force-pushed the asottile-types-group-serializer branch from 866c37e to c06fbc3 Compare January 16, 2025 19:17
@asottile-sentry asottile-sentry requested a review from a team as a code owner January 16, 2025 19:17
@asottile-sentry asottile-sentry force-pushed the asottile-types-group-serializer branch 2 times, most recently from 23949ce to f591ede Compare January 16, 2025 19:23
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/serializers/models/group_stream.py 73.33% 4 Missing ⚠️
src/sentry/tagstore/snuba/backend.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #83598   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files        9492     9492           
  Lines      539195   539210   +15     
  Branches    21218    21218           
=======================================
+ Hits       472243   472264   +21     
+ Misses      66603    66597    -6     
  Partials      349      349           

@asottile-sentry asottile-sentry enabled auto-merge (squash) January 17, 2025 15:00
@asottile-sentry asottile-sentry merged commit 3808265 into master Jan 17, 2025
48 of 49 checks passed
@asottile-sentry asottile-sentry deleted the asottile-types-group-serializer branch January 17, 2025 15:00
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants