feat(uptime): Propagate checker configs to redis as well as kafka #84151
+165
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Comment on lines
+82
to
+84
| def get_partition_keys(subscription_id: UUID) -> tuple[str, str]: | ||
| partition = get_partition_from_subscription_id(subscription_id) | ||
| return f"uptime:configs:{partition}", f"uptime:updates:{partition}" |
There was a problem hiding this comment.
nit: Sort of prefer this to be two functions, just so the naming is a bit more clear.
though you can pretty much tell from looking at the return strings, and at the call site what the unwrapped values are
| pipe = cluster.pipeline() | ||
| if value is None: | ||
| pipe.hdel(config_key, key) | ||
| action = "delete" |
There was a problem hiding this comment.
Would be nice to have a type for this, maybe a dataclass that knows how to serialize itself
@dataclass
class ConfigUpdate():
action: Literal["delete" | "upsert"]
subscription_id: Uuid
def as_msgpack(self):
return msgpack.packb(
{
"action": self.action,
"subscription_id": self.subscription_id.hex,
}
)There was a problem hiding this comment.
potentially could be redis aware as well
@property
def redis_update_key(self):
partition = get_partition_from_subscription_id(self.subscription_id)
return f"uptime:updates:{partition}"Just a thought
evanpurkhiser
approved these changes
Jan 28, 2025
This propagates our checker configs to our new redis config store. For the moment we're dual writing, but we'll remove the Kafka code once it is stable and running in prod.
evanpurkhiser
force-pushed
the
danf/uptime-config-propagate-redis
branch
from
11594aa to
4676e0a
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
…4151) This propagates our checker configs to our new redis config store. For the moment we're dual writing, but we'll remove the Kafka code once it is stable and running in prod. <!-- Describe your PR here. -->
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
…4151) This propagates our checker configs to our new redis config store. For the moment we're dual writing, but we'll remove the Kafka code once it is stable and running in prod. <!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propagates our checker configs to our new redis config store. For the moment we're dual writing, but we'll remove the Kafka code once it is stable and running in prod.