fix(aci milestone 3): update the resolve datacondition when we update triggers #84202
+206
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
reviewed
Feb 5, 2025
| if critical_data_condition is None: | ||
| logger.error( | ||
| "no data conditions exist for detector data condition group", | ||
| "no critical or warning data conditions exist for detector data condition group", | ||
| extra={"detector_data_condition_group": detector_triggers}, | ||
| ) | ||
| return -1 |
There was a problem hiding this comment.
I think I missed this in previous reviews, but why are we returning -1 instead of like none?
There was a problem hiding this comment.
Just an arbitrary integer value that is impossible as a valid threshold
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ceorourke
reviewed
Feb 5, 2025
tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py
Show resolved
Hide resolved
Comment on lines
+852
to
+856
| self.create_member( | ||
| user=self.user, organization=self.organization, role="owner", teams=[self.team] | ||
| ) | ||
|
|
||
| self.login_as(self.user) |
There was a problem hiding this comment.
can you put this into setup to avoid repeating it in each test?
ceorourke
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we update the a legacy alert rule's triggers, then we may have to update the resolution threshold on the resolve detector trigger (if no resolution threshold was specified on the alert rule). Create this update helper and add it to the serializer.
To facilitate this, I also updated the way we automatically get the resolution threshold. Now, instead of checking for the number of data conditions, we explicitly check for the critical and (optionally) warning data conditions, which we know have been previously dual written.