fix(sentry apps): Catch all errors so components doesn't blow up #84204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
approved these changes
Jan 29, 2025
| @@ -196,3 +197,42 @@ def test_component_prep_errors_are_isolated(self, run): | |||
| ] | |||
|
|
|||
| assert response.data == expected | |||
|
|
|||
| @patch("sentry.sentry_apps.components.SentryAppComponentPreparer.run") | |||
| def test_component_prep_errors_dont_bring_down_everything(self, run): | |||
Co-authored-by: Cathy Teng <[email protected]>
Christinarlong
deleted the
crl/backstop-to-handle-new-errors-incomponents
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, because we only catch
APIErrorerrors inSentryAppComponentsif we trigger some other error during the component process, the endpoint blows up and no ui components are shown. For now let's catch all of them whilst we wait for #84187