Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(widget-builder): Remove circular dependency in analytics #84289

Conversation

narsaynorath
Copy link
Member

Analytics was importing this type, which came from a file that imported analytics. Move the type into its own file to resolve some of these conflicts.

Analytics was importing this type, which came from a file that imported
analytics. Move the type into its own file to resolve some of these
conflicts.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 30, 2025
@narsaynorath narsaynorath marked this pull request as ready for review January 30, 2025 15:21
@narsaynorath narsaynorath requested a review from a team as a code owner January 30, 2025 15:21
@narsaynorath narsaynorath requested review from nikkikapadia and removed request for a team January 30, 2025 15:21
Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@narsaynorath narsaynorath merged commit 5170a7c into master Jan 30, 2025
43 checks passed
@narsaynorath narsaynorath deleted the nar/test/widget-builder-fix-circular-dependencies-in-visualize branch January 30, 2025 15:35
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
Analytics was importing this type, which came from a file that imported
analytics. Move the type into its own file to resolve some of these
conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants