-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(seer): revamped checkout #91815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isabellaenriquez
wants to merge
11
commits into
master
Choose a base branch
from
isabella/checkout-w-seer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91815 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 10347 10347
Lines 586415 586415
Branches 22560 22560
=======================================
Hits 430324 430324
Misses 155645 155645
Partials 446 446 |
brendanhsentry
approved these changes
May 16, 2025
<QuestionTooltip | ||
size="xs" | ||
title={t( | ||
'%s use budgets from your monthly reserved cost. Any additional usage will be from your PAYG budget.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
'%s use budgets from your monthly reserved cost. Any additional usage will be from your PAYG budget.', | |
'%s uses budgets from your monthly reserved cost. Any additional usage will be from your PAYG budget.', |
jarrettscott
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-610/implement-the-final-checkout-design
See demo at https://sentry.slack.com/archives/C08RLEM3JGP/p1747426914955719
Relies on https://github.com/getsentry/getsentry/pull/17507