Skip to content

fix(tests): Fix number of values unpacked #91825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke requested a review from a team May 16, 2025 20:37
@mifu67
Copy link
Contributor

mifu67 commented May 16, 2025

#91823 I fix this here

Copy link

codecov bot commented May 16, 2025

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156897 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
25883 2 25881 269
View the top 2 failed test(s) by shortest run time
tests.sentry.incidents.endpoints.test_organization_alert_rule_details.AlertRuleDetailsPutEndpointTest::test_workflow_engine_serializer
Stack Traces | 3.91s run time
#x1B[1m#x1B[.../incidents/endpoints/test_organization_alert_rule_details.py#x1B[0m:722: in test_workflow_engine_serializer
    self.critical_detector_trigger, _ = migrate_metric_data_conditions(critical_trigger)
#x1B[1m#x1B[31mE   ValueError: too many values to unpack (expected 2)#x1B[0m
tests.sentry.incidents.endpoints.test_organization_alert_rule_details.AlertRuleDetailsGetEndpointTest::test_workflow_engine_serializer
Stack Traces | 4.64s run time
#x1B[1m#x1B[.../incidents/endpoints/test_organization_alert_rule_details.py#x1B[0m:239: in test_workflow_engine_serializer
    self.critical_detector_trigger, _ = migrate_metric_data_conditions(critical_trigger)
#x1B[1m#x1B[31mE   ValueError: too many values to unpack (expected 2)#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants