Skip to content

feat(taxonomy): Add setup prompts to empty states #91828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

MichaelSun48
Copy link
Member

Adds a bullet point to the taxonomy views (except user feedback) prompting users to setup telemetry that would populate those views:

Errors & Outages:

image

Breached Metrics & Warnings:

image

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner May 16, 2025 20:54
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 16, 2025
@MichaelSun48 MichaelSun48 requested a review from a team May 19, 2025 17:30
)}
{onErrorsAndOutagesView && (
<li>
{tct('Make sure uptime monitoring is set up in your project. [link]', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And cron monitoring

The learn mores feel weird - thoughts on just linking to those inline? Ex: "Make sure [cron] and [uptime] monitoring are set up in your project." and "Make sure [tracing] is set up in your project."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i like that! the learn more was just following the pattern from bullet point above

@MichaelSun48 MichaelSun48 merged commit 0f4d578 into master May 19, 2025
41 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/sharedViews/addSetupPromptToEmptyState branch May 19, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants