Skip to content

fix(taskworker) Don't send project to find_channel_id_for_rule #91848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(taskworker) Don't send project to find_channel_id_for_rule #91848

wants to merge 1 commit into from

Conversation

markstory
Copy link
Member

Continues #91810 by changing the call sites to not pass project anymore.

@markstory
fix(taskworker) Don't send project to find_channel_id_for_rule
a514ed5 
Continues #91810 by changing the call sites to not pass `project`
anymore.
@markstory markstory requested a review from a team as a code owner May 16, 2025 23:33
@markstory markstory requested a review from a team May 16, 2025 23:33
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2025
@codecov Codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156898 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #91848       +/-   ##
===========================================
+ Coverage   32.72%   87.63%   +54.90%     
===========================================
  Files        8751    10356     +1605     
  Lines      487749   586780    +99031     
  Branches    22586    22586               
===========================================
+ Hits       159629   514217   +354588     
+ Misses     327695    72138   -255557     
  Partials      425      425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markstory