Skip to content

test(rules): Improve type coverage #91849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(rules): Improve type coverage #91849

wants to merge 1 commit into from

Conversation

kcons
Copy link
Member

@kcons kcons commented May 16, 2025

Change CallbackFuture and RuleFuture to typed namedtuples, with some tweaks to make existing interactions typecheck correctly.

@kcons kcons requested review from a team as code owners May 16, 2025 23:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2025
Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156898 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Files with missing lines Patch % Lines
.../rules/actions/integrations/create_ticket/utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91849       +/-   ##
===========================================
+ Coverage   32.72%   87.63%   +54.90%     
===========================================
  Files        8751    10356     +1605     
  Lines      487748   586786    +99038     
  Branches    22586    22586               
===========================================
+ Hits       159617   514210   +354593     
+ Misses     327706    72151   -255555     
  Partials      425      425               

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant