Skip to content

Commit

Permalink
fix(ourlogs): Logs trace item table should support offset
Browse files Browse the repository at this point in the history
We need to be able to paginate, this adds offset similar to the eap spans trace items table.
  • Loading branch information
k-fish authored Mar 5, 2025
1 parent 3b35784 commit bfe69dd
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ def _build_query(request: TraceItemTableRequest) -> Query:
groupby=[
attribute_key_to_expression(attr_key) for attr_key in request.group_by
],
# Only support offset page tokens for now
offset=request.page_token.offset,
# protobuf sets limit to 0 by default if it is not set,
# give it a default value that will actually return data
limit=request.limit if request.limit > 0 else _DEFAULT_ROW_LIMIT,
Expand Down

0 comments on commit bfe69dd

Please sign in to comment.