comment

getsentry · Feb 18, 2025 · ce2571e · ce2571e
1 parent f70521a
commit ce2571e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/snuba/web/rpc/v1/endpoint_trace_item_table.py b/snuba/web/rpc/v1/endpoint_trace_item_table.py
@@ -88,6 +88,10 @@ def _transform_request(request: TraceItemTableRequest) -> TraceItemTableRequest:
 
 
 def convert_to_conditional_aggregation(in_msg: TraceItemTableRequest) -> None:
+    """
+    This function adds the equivalent conditional aggregation for every aggregation in each Column or AggregationFilter. We don't add the filter field so outside code logic will set the default condition to true. The purpose of this function is to "transform" every AttributeAggregation to AttributeConditionalAggregation in order to avoid code fragmentation
+    """
+
     def _add_conditional_aggregation(
         input: Column | AggregationComparisonFilter,
     ) -> None:

diff --git a/tests/web/rpc/v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table.py b/tests/web/rpc/v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table.py
@@ -2798,12 +2798,6 @@ def _build_sum_attribute_aggregation_column_with_name(name: str) -> Column:
 
 def _build_sum_attribute_conditional_aggregation_column_with_name(name: str) -> Column:
     return Column(
-        aggregation=AttributeAggregation(
-            aggregate=Function.FUNCTION_SUM,
-            key=AttributeKey(type=AttributeKey.TYPE_DOUBLE, name=name),
-            label="sum(" + name + ")",
-            extrapolation_mode=ExtrapolationMode.EXTRAPOLATION_MODE_NONE,
-        ),
         conditional_aggregation=AttributeConditionalAggregation(
             aggregate=Function.FUNCTION_SUM,
             key=AttributeKey(type=AttributeKey.TYPE_DOUBLE, name=name),