Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eap-items): Use the subscriptable bucket mapper for EAP items #6908

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

colin-sentry
Copy link
Member

We need to use this for logs

@colin-sentry colin-sentry requested review from a team as code owners February 24, 2025 19:40
Copy link

codecov bot commented Feb 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2209 1 2208 11
View the top 1 failed test(s) by shortest run time
tests.query.processors.test_hash_bucket_functions_processor::test_format_expressions[pre_format0-expected_query0]
Stack Traces | 0.006s run time
Traceback (most recent call last):
  File ".../query/processors/test_hash_bucket_functions_processor.py", line 226, in test_format_expressions
    assert copy.get_selected_columns() == expected_query.get_selected_columns()
AssertionError: assert [SelectedExpression(name='keys',\n                    expression=arrayConcat(\n  mapKeys(\n    attr_str_0\n  ),\n  mapKeys(\n    attr_str_1\n  ),\n  mapKeys(\n    attr_str_2\n  ),\n  mapKeys(\n    attr_str_3\n  ),\n  mapKeys(\n    attr_str_4\n  )\n) AS `alias`),\n SelectedExpression(name='unrelated', expression=column2),\n SelectedExpression(name='unrelated_map',\n                    expression=mapKeys(\n  attr_stru\n) AS `aliasunrelatedmap`)] == [SelectedExpression(name='keys',\n                    expression=arrayConcat(\n  mapKeys(\n    attr_str_0\n  ),\n  mapKeys(\n    attr_str_1\n  ),\n  mapKeys(\n    attr_str_2\n  ),\n  mapKeys(\n    attr_str_3\n  ),\n  mapKeys(\n    attr_str_4\n  ),\n  mapKeys(\n    attr_str_5\n  ),\n  mapKeys(\n    attr_str_6\n  ),\n  mapKeys(\n    attr_str_7\n  ),\n  mapKeys(\n    attr_str_8\n  ),\n  mapKeys(\n    attr_str_9\n  ),\n  mapKeys(\n    attr_str_10\n  ),\n  mapKeys(\n    attr_str_11\n  ),\n  mapKeys(\n    attr_str_12\n  ),\n  mapKeys(\n    attr_str_13\n  ),\n  mapKeys(\n    attr_str_14\n  ),\n  mapKeys(\n    attr_str_15\n  ),\n  mapKeys(\n    attr_str_16\n  ),\n  mapKeys(\n    attr_str_17\n  ),\n  mapKeys(\n    attr_str_18\n  ),\n  mapKeys(\n    attr_str_19\n  )\n) AS `alias`),\n SelectedExpression(name='unrelated', expression=column2),\n SelectedExpression(name='unrelated_map',\n                    expression=mapKeys(\n  attr_stru\n) AS `aliasunrelatedmap`)]
  At index 0 diff: SelectedExpression(name='keys', expression=arrayConcat(\n  mapKeys(\n    attr_str_0\n  ),\n  mapKeys(\n    attr_str_1\n  ),\n  mapKeys(\n    attr_str_2\n  ),\n  mapKeys(\n    attr_str_3\n  ),\n  mapKeys(\n    attr_str_4\n  )\n) AS `alias`) != SelectedExpression(name='keys', expression=arrayConcat(\n  mapKeys(\n    attr_str_0\n  ),\n  mapKeys(\n    attr_str_1\n  ),\n  mapKeys(\n    attr_str_2\n  ),\n  mapKeys(\n    attr_str_3\n  ),\n  mapKeys(\n    attr_str_4\n  ),\n  mapKeys(\n    attr_str_5\n  ),\n  mapKeys(\n    attr_str_6\n  ),\n  mapKeys(\n    attr_str_7\n  ),\n  mapKeys(\n    attr_str_8\n  ),\n  mapKeys(\n    attr_str_9\n  ),\n  mapKeys(\n    attr_str_10\n  ),\n  mapKeys(\n    attr_str_11\n  ),\n  mapKeys(\n    attr_str_12\n  ),\n  mapKeys(\n    attr_str_13\n  ),\n  mapKeys(\n    attr_str_14\n  ),\n  mapKeys(\n    attr_str_15\n  ),\n  mapKeys(\n    attr_str_16\n  ),\n  mapKeys(\n    attr_str_17\n  ),\n  mapKeys(\n    attr_str_18\n  ),\n  mapKeys(\n    attr_str_19\n  )\n) AS `alias`)
  Full diff:
    [
     SelectedExpression(name='keys',
                        expression=arrayConcat(
      mapKeys(
        attr_str_0
      ),
      mapKeys(
        attr_str_1
      ),
      mapKeys(
        attr_str_2
      ),
      mapKeys(
        attr_str_3
      ),
      mapKeys(
        attr_str_4
  -   ),
  -   mapKeys(
  -     attr_str_5
  -   ),
  -   mapKeys(
  -     attr_str_6
  -   ),
  -   mapKeys(
  -     attr_str_7
  -   ),
  -   mapKeys(
  -     attr_str_8
  -   ),
  -   mapKeys(
  -     attr_str_9
  -   ),
  -   mapKeys(
  -     attr_str_10
  -   ),
  -   mapKeys(
  -     attr_str_11
  -   ),
  -   mapKeys(
  -     attr_str_12
  -   ),
  -   mapKeys(
  -     attr_str_13
  -   ),
  -   mapKeys(
  -     attr_str_14
  -   ),
  -   mapKeys(
  -     attr_str_15
  -   ),
  -   mapKeys(
  -     attr_str_16
  -   ),
  -   mapKeys(
  -     attr_str_17
  -   ),
  -   mapKeys(
  -     attr_str_18
  -   ),
  -   mapKeys(
  -     attr_str_19
      )
    ) AS `alias`),
     SelectedExpression(name='unrelated', expression=column2),
     SelectedExpression(name='unrelated_map',
                        expression=mapKeys(
      attr_stru
    ) AS `aliasunrelatedmap`),
    ]

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@colin-sentry colin-sentry enabled auto-merge (squash) February 24, 2025 21:16
@colin-sentry colin-sentry merged commit 2525fb7 into master Feb 24, 2025
32 checks passed
@colin-sentry colin-sentry deleted the eap_use_bucket_mapper branch February 24, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants