-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ourlogs): Read and write ourlogs from the new items table #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
colin-sentry
commented
Feb 25, 2025
- Creates a new temporary storage to bridge the existing kafka topic with the new clickhouse table
- Modifies consumer to point to the new items table
- Modifies querying code to point to new items table
8674d46
to
05e00f3
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
8a1d8bf
to
8ea35ac
Compare
phacops
approved these changes
Feb 25, 2025
colin-sentry
added a commit
to getsentry/sentry
that referenced
this pull request
Feb 25, 2025
It also disables the test for now, circular dependency with getsentry/snuba#6911
colin-sentry
added a commit
to getsentry/sentry
that referenced
this pull request
Feb 25, 2025
These tests can be re-enabled now that [this snuba PR](getsentry/snuba#6911) is merged
volokluev
pushed a commit
that referenced
this pull request
Feb 27, 2025
- Creates a new temporary storage to bridge the existing kafka topic with the new clickhouse table - Modifies consumer to point to the new items table - Modifies querying code to point to new items table
ameliahsu
pushed a commit
to getsentry/sentry
that referenced
this pull request
Mar 5, 2025
These tests can be re-enabled now that [this snuba PR](getsentry/snuba#6911) is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.