Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ourlogs): Read and write ourlogs from the new items table #6911

Merged
merged 13 commits into from
Feb 25, 2025

Conversation

colin-sentry
Copy link
Member

  • Creates a new temporary storage to bridge the existing kafka topic with the new clickhouse table
  • Modifies consumer to point to the new items table
  • Modifies querying code to point to new items table

@colin-sentry colin-sentry requested review from a team as code owners February 25, 2025 15:36
@colin-sentry colin-sentry force-pushed the ourlogs_to_items_table branch from 8674d46 to 05e00f3 Compare February 25, 2025 15:39
Copy link

codecov bot commented Feb 25, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2795 1 2794 11
View the top 1 failed test(s) by shortest run time
tests.web.rpc.v1.test_R_ourlogs.test_logs_expression_converters.TestOurlogsExpressionConverters::test_normalized_col
Stack Traces | 0.002s run time
Traceback (most recent call last):
  File ".../v1/test_R_ourlogs/test_logs_expression_converters.py", line 57, in test_normalized_col
    assert attribute_key_to_expression(
AssertionError: assert arrayElement(\n  attributes_string,\n  'sentry.span_id'\n) AS `sentry.span_id_TYPE_STRING` == span_id AS `sentry.span_id`
  Full diff:
  - span_id AS `sentry.span_id`
  + arrayElement(
  +   attributes_string,
  +   'sentry.span_id'
  + ) AS `sentry.span_id_TYPE_STRING`

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

colin-sentry added a commit to getsentry/sentry that referenced this pull request Feb 25, 2025
It also disables the test for now, circular dependency with
getsentry/snuba#6911
@colin-sentry colin-sentry enabled auto-merge (squash) February 25, 2025 17:21
@colin-sentry colin-sentry merged commit 551ed4f into master Feb 25, 2025
32 checks passed
@colin-sentry colin-sentry deleted the ourlogs_to_items_table branch February 25, 2025 17:34
colin-sentry added a commit to getsentry/sentry that referenced this pull request Feb 25, 2025
These tests can be re-enabled now that [this snuba
PR](getsentry/snuba#6911) is merged
volokluev pushed a commit that referenced this pull request Feb 27, 2025
- Creates a new temporary storage to bridge the existing kafka topic
with the new clickhouse table
- Modifies consumer to point to the new items table
- Modifies querying code to point to new items table
ameliahsu pushed a commit to getsentry/sentry that referenced this pull request Mar 5, 2025
These tests can be re-enabled now that [this snuba
PR](getsentry/snuba#6911) is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants