feat(ourlogs): Add item type check to resolver #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
reviewed
Feb 25, 2025
Comment on lines
-71
to
+75
| for column in request.columns: | ||
| if column.HasField("key"): | ||
| key_col = attribute_key_to_expression(column.key) | ||
| for col in request.columns: | ||
| if col.HasField("key"): | ||
| key_col = attribute_key_to_expression(col.key) |
There was a problem hiding this comment.
python hoists the column out of the loop scope to shadow the import, makes pypy mad
phacops
approved these changes
Feb 26, 2025
volokluev
pushed a commit
that referenced
this pull request
Feb 27, 2025
Now that trace_item_table is the union of both logs and spans, send item_type in the `WHERE` clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that trace_item_table is the union of both logs and spans, send item_type in the
WHEREclause