Skip to content

Commit

Permalink
fix(sidecar): invalid semver range for source-map (#667)
Browse files Browse the repository at this point in the history
Fixes #668 

## Issue

The range specified isn't technically correct (pnpm accepts this though). Check with semver

![image](https://github.com/user-attachments/assets/3f003ad0-85b7-4bc6-bbae-b81d43903496)

The fix is simple:

![image](https://github.com/user-attachments/assets/0908d33c-221c-4b9e-9f2e-d9d2c0e84eab)

## Workaround till fixed upstream

```json5
  "resolutions": {
    "source-map": ">=0.8.0-beta <0.9.0"
  },
```
  • Loading branch information
belgattitude authored Jan 23, 2025
1 parent 044d00d commit 416fecd
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 14 deletions.
5 changes: 5 additions & 0 deletions .changeset/new-bats-shake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@spotlightjs/sidecar': patch
---

Fix invalid semver range for source-map dependency
2 changes: 1 addition & 1 deletion packages/sidecar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@sentry/node": "^8.42.0",
"kleur": "^4.1.5",
"launch-editor": "^2.9.1",
"source-map": ">=0.8.0-beta && <1.0.0"
"source-map": ">=0.8.0-beta.0 <0.9.0"
},
"devDependencies": {
"@spotlightjs/tsconfig": "workspace:*",
Expand Down
28 changes: 15 additions & 13 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 416fecd

Please sign in to comment.