fix: Don't crash when score.total is missing (#682)

Fixes #681.
getsentry · Jan 29, 2025 · 52ceec5 · 52ceec5
1 parent 0da237f
commit 52ceec5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/rude-tomatoes-brush.md b/.changeset/rude-tomatoes-brush.md
@@ -0,0 +1,8 @@
+---
+'@spotlightjs/spotlight': patch
+'@spotlightjs/electron': patch
+'@spotlightjs/overlay': patch
+'@spotlightjs/astro': patch
+---
+
+Fix rare error when `score.total` is missing from `measurements`
diff --git a/packages/overlay/src/integrations/sentry/utils/webVitals.ts b/packages/overlay/src/integrations/sentry/utils/webVitals.ts
@@ -1,5 +1,5 @@
-import { SentryEvent } from '~/integrations/sentry/types';
-import { WebVitals } from '../constants';
+import type { SentryEvent } from '~/integrations/sentry/types';
+import type { WebVitals } from '../constants';
 
 const SQRT_2 = Math.sqrt(2);
 
@@ -155,7 +155,7 @@ export function normalizePerformanceScore(
         };
       }
 
-      if (shouldAddTotal) {
+      if (shouldAddTotal && !Object.prototype.hasOwnProperty.call(measurements, 'score.total')) {
         measurements['score.total'] = {
           value: scoreTotal,
           unit: 'ratio',