Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various #666

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Various #666

merged 2 commits into from
Jan 22, 2025

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jan 22, 2025

PR will be useless, just sticking some commits into one PR to simplify things and will rebase.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 7:03pm

@dcramer
Copy link
Member Author

dcramer commented Jan 22, 2025

image

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.29%. Comparing base (4bf3776) to head (b4c57a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   31.35%   31.29%   -0.06%     
==========================================
  Files          92       92              
  Lines        5435     5435              
  Branches      100      100              
==========================================
- Hits         1704     1701       -3     
- Misses       3731     3734       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Million times better, ship it 🚀

@dcramer dcramer merged commit 044d00d into main Jan 22, 2025
16 of 17 checks passed
@dcramer dcramer deleted the feat/improvements branch January 22, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants