Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Less indentation for deep trees with single child #686

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Feb 3, 2025

Before:
image

After:
image

Before:

image

After:

image

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 8:59pm

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 31.76%. Comparing base (63f2403) to head (9c0b936).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...entry/components/explore/traces/spans/SpanItem.tsx 0.00% 6 Missing ⚠️
...entry/components/explore/traces/spans/SpanTree.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   31.76%   31.76%           
=======================================
  Files          92       92           
  Lines        5519     5521    +2     
  Branches      100      100           
=======================================
+ Hits         1753     1754    +1     
- Misses       3766     3767    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcramer
Copy link
Member

dcramer commented Feb 3, 2025

I dont LOVE the solution, but I'm also struggling to come up w/ a better idea. We still have this issue on production Sentry too and its kind of a disaster...

@BYK
Copy link
Member Author

BYK commented Feb 3, 2025

TBH this is quite a hacky solution and I certainly don't like it much. However until we can do better design and span grouping, this solution is the best bang for the buck.

With the upcoming profiling work, it is a necessity as profiles can go deep fast with 1-child trees.

@dcramer
Copy link
Member

dcramer commented Feb 3, 2025

I'm good w/ this - @vuluongj20 mentioned we tried an approach with a dashed line that would simply collapse a lot of these single child spans. I htink something akin to that is the right direction, but the dashed implementation IMO is still not obvious enough.

We'll follow up with something better in future.

@vuluongj20
Copy link
Member

Here's a screenshot for reference
image
Agree that it's not super obvious what the dashed line means. We can consider other visual cues.

@BYK
Copy link
Member Author

BYK commented Feb 4, 2025

Created #686 for a proper follow up.

@BYK BYK merged commit 9c498dd into main Feb 4, 2025
16 of 17 checks passed
@BYK BYK deleted the npruowyltkpv branch February 4, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants