-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Less indentation for deep trees with single child #686
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 31.76% 31.76%
=======================================
Files 92 92
Lines 5519 5521 +2
Branches 100 100
=======================================
+ Hits 1753 1754 +1
- Misses 3766 3767 +1 ☔ View full report in Codecov by Sentry. |
I dont LOVE the solution, but I'm also struggling to come up w/ a better idea. We still have this issue on production Sentry too and its kind of a disaster... |
TBH this is quite a hacky solution and I certainly don't like it much. However until we can do better design and span grouping, this solution is the best bang for the buck. With the upcoming profiling work, it is a necessity as profiles can go deep fast with 1-child trees. |
I'm good w/ this - @vuluongj20 mentioned we tried an approach with a dashed line that would simply collapse a lot of these single child spans. I htink something akin to that is the right direction, but the dashed implementation IMO is still not obvious enough. We'll follow up with something better in future. |
Created #686 for a proper follow up. |
Before:

After:

Before:
After: