Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Unify and simplify duration calculations and representations #688

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Feb 4, 2025

No description provided.

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 0:01am

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 31.93%. Comparing base (9c498dd) to head (09cf311).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../overlay/src/integrations/sentry/utils/duration.ts 55.00% 9 Missing ⚠️
...ry/components/explore/traces/spans/SpanDetails.tsx 20.00% 4 Missing ⚠️
...entry/components/explore/traces/spans/SpanItem.tsx 33.33% 2 Missing ⚠️
...e/traces/TraceDetails/components/TraceTreeview.tsx 50.00% 1 Missing ⚠️
...ons/sentry/components/explore/traces/TraceList.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   31.82%   31.93%   +0.11%     
==========================================
  Files          92       92              
  Lines        5521     5476      -45     
  Branches      101      101              
==========================================
- Hits         1757     1749       -8     
+ Misses       3764     3727      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK merged commit 0fcb37d into main Feb 4, 2025
8 of 9 checks passed
@BYK BYK deleted the kusvlxmqwpvo branch February 4, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant