enhance: make mapping by params initialization optional (android deob…

…fuscation) (#823)

* Make parameter_mapping initialization (for android deobfuscation)
optional

CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## Unreleased
+
+**Internal**
+
+**Fixes**
+
+**Features**
+
+- Make mapping by params initialization optional ([#823](https://github.com/getsentry/symbolic/pull/823))
+
 ## 12.7.1
 
 **Internal**

py/symbolic/proguard.py

@@ -39,10 +39,14 @@ class ProguardMapper(RustObject):
     __dealloc_func__ = lib.symbolic_proguardmapper_free
 
     @classmethod
-    def open(cls, path: str) -> ProguardMapper:
+    def open(cls, path: str, initialize_param_mapping: bool = False) -> ProguardMapper:
         """Constructs a mapping file from a path."""
         return cls._from_objptr(
-            rustcall(lib.symbolic_proguardmapper_open, encode_path(path))
+            rustcall(
+                lib.symbolic_proguardmapper_open,
+                encode_path(path),
+                initialize_param_mapping,
+            )
         )
 
     @property

symbolic-cabi/Cargo.toml

@@ -20,7 +20,7 @@ publish = false
 crate-type = ["cdylib"]
 
 [dependencies]
-proguard = { version = "5.3.0", features = ["uuid"] }
+proguard = { version = "5.4.0", features = ["uuid"] }
 sourcemap = "7.0.0"
 symbolic = { version = "12.7.1", path = "../symbolic", features = ["cfi", "debuginfo", "sourcemapcache", "symcache"] }
 tempfile = "3.4.0"

symbolic-cabi/include/symbolic.h

@@ -500,7 +500,8 @@ struct SymbolicStr symbolic_normalize_debug_id(const struct SymbolicStr *debug_i
 /**
  * Creates a proguard mapping view from a path.
  */
-struct SymbolicProguardMapper *symbolic_proguardmapper_open(const char *path);
+struct SymbolicProguardMapper *symbolic_proguardmapper_open(const char *path,
+                                                            bool initialize_param_mapping);
 
 /**
  * Frees a proguard mapping view.

symbolic-cabi/src/proguard.rs

@@ -52,13 +52,18 @@ impl ForeignObject for SymbolicProguardMapper {
 ffi_fn! {
     /// Creates a proguard mapping view from a path.
     unsafe fn symbolic_proguardmapper_open(
-        path: *const c_char
+        path: *const c_char,
+        initialize_param_mapping: bool
     ) -> Result<*mut SymbolicProguardMapper> {
         let byteview = ByteView::open(CStr::from_ptr(path).to_str()?)?;
 
         let inner = SelfCell::new(byteview, |data| {
             let mapping = ProguardMapping::new(&*data);
-            let mapper = ProguardMapper::new(mapping.clone());
+            let mapper = if !initialize_param_mapping {
+                ProguardMapper::new(mapping.clone())
+            } else {
+                ProguardMapper::new_with_param_mapping(mapping.clone(), initialize_param_mapping)
+            };
             Inner { mapping, mapper }
         });