fix(sourcebundles): Skip invalid sources (#861)

getsentry · Aug 28, 2024 · b9c8405 · b9c8405
1 parent 7af6091
commit b9c8405
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Skip invalid sources ([#861](https://github.com/getsentry/symbolic/pull/861))
+
 ## 12.10.0
 
 **Features**

diff --git a/symbolic-debuginfo/src/sourcebundle.rs b/symbolic-debuginfo/src/sourcebundle.rs
@@ -1314,7 +1314,12 @@ where
                 info.set_ty(SourceFileType::Source);
                 info.set_path(filename.clone());
 
-                self.add_file(bundle_path, source, info)?;
+                if let Err(e) = self.add_file(bundle_path, source, info) {
+                    // Skip sources that are not UTF-8
+                    if e.kind != SourceBundleErrorKind::ReadFailed {
+                        return Err(e);
+                    };
+                }
             }
         }