Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Add sets #1600

Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat(metrics): Add sets #1600

merged 1 commit into from
Jan 23, 2025

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim self-assigned this Jan 23, 2025
@loewenheim loewenheim requested a review from a team January 23, 2025 13:32
@loewenheim loewenheim requested review from Dav1dde and a team January 23, 2025 13:34
@loewenheim loewenheim enabled auto-merge (squash) January 23, 2025 13:42
@loewenheim loewenheim merged commit 9820d59 into master Jan 23, 2025
15 checks passed
@loewenheim loewenheim deleted the feat/metric-sets branch January 23, 2025 13:44
@loewenheim loewenheim mentioned this pull request Jan 30, 2025
Merged
loewenheim added a commit that referenced this pull request Jan 30, 2025
@loewenheim
fix(metrics): Actually emit set metrics (#1606)
1fd7ec6 
#1600 added aggregation for set metrics
but neglected to actually emit them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-wilfert tobias-wilfert tobias-wilfert approved these changes

@iambriccardo iambriccardo iambriccardo approved these changes

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loewenheim @Dav1dde @iambriccardo @tobias-wilfert