Fix for categories list always showing a scrollbar #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately it doesn't seem to work on my test VM
|
|
That's Adapta, right? The issue still occured because that theme adds a margin to It's not very pretty, I know very little about Gtk. Maybe there's a nicer way to solve this? |
|
LGTM. It works fine with Adapta and I haven't noticed regression with a few other random themes. |
|
This is probably how I would've done it as well, to be fair. LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for an issue from the old repo: solus-project/brisk-menu#83
The problem is that
gtk_widget_get_preferred_heightexpects the height to include the border width as well. Therefore, on themes* that have a border aroundBriskMenuSidebarScroller, the scroller will always be a few pixels shorter.(*) https://github.com/ubuntu-mate/ubuntu-mate-artwork/blob/master/usr/share/themes/Ambiant-MATE/gtk-3.0/apps/mate-applications.css#L694