zellij: Housekeeping #3303
Merged
zellij: Housekeeping #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EbonJaeger
reviewed
Jul 14, 2024
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <component type="desktop-application"> | |||
There was a problem hiding this comment.
zellij is a terminal application; is this the right component?
There was a problem hiding this comment.
Oh, I thought it was more like kitty. Now that i tried it, it is more like helix. Yeah, this is not the right component. But then again, it provides desktop file which console application are not required to. For console application, this the template for it.
There was a problem hiding this comment.
I think the component can be changed to <component type="console-application"> and will still be valid. Let me try in a sec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Verify metainfo with appstream-builder --packages-dir=. --include-failed -v
Checklist