Refactor cache #24
Closed
Refactor cache #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we have to manually hard code cache directories. Now, future developers can simply define another `Cache` struct in `builder/cache.go` to add another cache. Signed-off-by: Gavin Zhao <[email protected]>
… directories Signed-off-by: Gavin Zhao <[email protected]>
|
This looks good to be. Only thing is the |
| // LegacySccacheDirectory is the root owned ccache directory for pspec.xml | ||
| LegacySccacheDirectory = "/var/lib/solbuild/sccache/legacy" | ||
| // CacheDirectory is where we store build cache for all packages. | ||
| CacheDirectory = "/var/lib/solbuild/cache" |
There was a problem hiding this comment.
// Obsolete cache directories. These are only still specified so that the
// `delete-cache -a` subcommand will remove them. In the future they will
// be removed.
ObsoleteCcacheDirectory = "/var/lib/solbuild/ccache/ypkg"
ObsoleteLegacyCcacheDirectory = "/var/lib/solbuild/ccache/legacy"
ObsoleteSccacheDirectory = "/var/lib/solbuild/sccache/ypkg"
ObsoleteLegacySccacheDirectory = "/var/lib/solbuild/sccache/legacy"
| builder.PackageCacheDirectory, | ||
| source.SourceDir, | ||
| builder.CacheDirectory, |
There was a problem hiding this comment.
builder.ObsoleteCcacheDirectory,
builder.ObsoleteLegacyCcacheDirectory,
builder.ObsoleteSccacheDirectory,
builder.ObsoleteLegacySccacheDirectory,
|
I also think it's safe to remove ccache/sccache support from legacy xml builds. In Solus we only have 4 pkgs that are using the old format and none of them really need ccache/sccache support. |
Merged
|
Superseded by #36. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23.