Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/clin data updates concept 2 #89

Merged
merged 20 commits into from
Feb 9, 2024
Merged

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Feb 8, 2024

Alternative to #87 (likely merge this one and close the other).

@cconrad8 So we could do a separate template for ovarian cohort or we could use the current core one. But since there is a lot of overlap, I agree keeping in it in the same template to keep it simple. Click on the preview below, then in the template choose the right Cohort to highlight the more specific attributes.
image

Copy link

github-actions bot commented Feb 8, 2024

Test Suite Report

Template Generation

template result link
BulkMethylation-seqLevel1 😄 template link
BulkMethylation-seqLevel2 😄 template link
BulkMethylation-seqLevel3 😄 template link
CohortCoreTemplate 😄 template link
ImagingLevel2 😄 template link
ImagingLevel2Channels 😄 template link
ScRNA-seqLevel1 😄 template link
ScRNA-seqLevel2 😄 template link
ScRNA-seqLevel3 😄 template link
ScRNA-seqLevel4 😄 template link

Manifest Validation

TODO

@anngvu anngvu requested a review from cconrad8 February 9, 2024 14:52
@cconrad8
Copy link
Contributor

cconrad8 commented Feb 9, 2024

@anngvu yes this is very nice! I like the one template

@anngvu anngvu merged commit 49ec66c into main Feb 9, 2024
@cconrad8
Copy link
Contributor

cconrad8 commented Feb 9, 2024

@anngvu not related to this PR, but it's not clear to me where "Class BRCA1 and class BRCA2" originated from and what the expected fields are - do you have info on that?

@anngvu
Copy link
Contributor Author

anngvu commented Feb 9, 2024

@cconrad8 Glad you asked! It stands for "classification of the BRCA mutation pathogenicity". Here's an early example of what classBRCA1/2 was going to be used for: https://github.com/gf-dcc/data-model/blob/main/drafts/core_sample.json#L8. This was supposed to address #9. You can add the description and make sure they're linked to the right enum definitions, which would help finally close #9 and #88 😃 !

This was linked to issues Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeContraceptiveUse Add SurgeryReason to Cohort Core
3 participants